Fix adapter thread exit crash issue to enable graceful adapter shutdown.#2506
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
==========================================
+ Coverage 66.73% 66.75% +0.02%
==========================================
Files 121 121
Lines 27528 27545 +17
==========================================
+ Hits 18370 18389 +19
+ Misses 9158 9156 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fengzeroz
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix adapter thread exit crash issue to enable graceful adapter shutdown.
Before exiting the program, the adapter would crash because the adapter thread forcefully terminated, preventing the plugin's stop method from being called in time. Later, an elegant shutdown method was added.